Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce lint rule no_dupe_key to forbid duplicated entries in an object #4322

Merged
merged 2 commits into from
Aug 2, 2016
Merged

Introduce lint rule no_dupe_key to forbid duplicated entries in an object #4322

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06d98d9
Introduce lint rule no_dupe_key to forbid duplicated entries in an ob…
lannka Aug 2, 2016
4d1d9ad
Merge branch 'master' into lint_no_dupe_key
lannka Aug 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@
"no-array-destructuring": 2,
"no-debugger": 2,
"no-div-regex": 2,
"no-dupe-keys": 2,
"no-eval": 2,
"no-extend-native": 2,
"no-extra-bind": 2,
Expand Down
1 change: 0 additions & 1 deletion src/3p-frame.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ function getFrameAttributes(parentWindow, element, opt_type) {
tagName: element.tagName,
mode: getModeObject(),
hidden: !viewer.isVisible(),
startTime,
amp3pSentinel: generateSentinel(parentWindow),
initialIntersection: getIntersectionChangeEntry(
timer.now(),
Expand Down
2 changes: 0 additions & 2 deletions test/functional/test-runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import {
getServicePromise,
getServicePromiseOrNullForDoc,
} from '../../src/service';
import {parseUrl} from '../../src/url';
import {platformFor} from '../../src/platform';
import * as ext from '../../src/service/extensions-impl';
import * as extel from '../../src/extended-element';
Expand Down Expand Up @@ -56,7 +55,6 @@ describe('runtime', () => {
history: {},
navigator: {},
setTimeout: () => {},
location: parseUrl('https://acme.com/document1'),
Object,
HTMLElement,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one would have one out.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me the URL is not used in the test. Or did I miss something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review the tests. If it passes, LGTM.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests passed. PTAL :-)

services: {
Expand Down