Fixes viewer swipe not pausing videos on subsequent plays #4385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
changed the title
|
LGTM |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4363
This was caught by error logging @jridgewell suggested we add to #4137 👏
So in the VSM, going from
visible || hiddentoinactivecallsunloadwhich itself also callspauseon all resources. The issue is coming back frominvisibleto those states, does not callresumewhich means all components stay paused (paused_ == true) which is not correct.This PR causes
inactivetovisible || hiddenstate change to call resume in addition to doing a pass.