Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In test env, redirect URL with /base/* to /*. #4458

Merged
merged 2 commits into from
Aug 11, 2016
Merged

In test env, redirect URL with /base/* to /*. #4458

merged 2 commits into from
Aug 11, 2016

Conversation

lannka
Copy link
Contributor

@lannka lannka commented Aug 11, 2016

Addresses #4452

@erwinmombay
Copy link
Member

LGTM, deferring to @muxin for final LGTM

@muxin
Copy link
Contributor

muxin commented Aug 11, 2016

LGTM

@muxin muxin added LGTM and removed NEEDS REVIEW labels Aug 11, 2016
@lannka lannka merged commit 1e92c99 into ampproject:master Aug 11, 2016
@lannka lannka deleted the remove_base branch August 11, 2016 22:26
ariangibson pushed a commit to Mixpo/amphtml that referenced this pull request Sep 7, 2016
@lannka @ariangibson
In test env, redirect URL with /base/* to /*. (ampproject#4458)
07d3415
mityaha pushed a commit to ooyala/amphtml that referenced this pull request Nov 30, 2016
@lannka @mityaha
In test env, redirect URL with /base/* to /*. (ampproject#4458)
0a818df
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erwinmombay erwinmombay

@muxin muxin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lannka @erwinmombay @muxin