Add Cache SW Kill File #4652
Merged
Add Cache SW Kill File #4652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows setting the `cache-service-worker-kill` "experiment" config. When set, the service worker will self destruct, returning us to the dark pre-SW days.
| * limitations under the License. | ||
| */ | ||
|
|
||
| import '../../third_party/babel/custom-babel-helpers'; |
There was a problem hiding this comment.
what do we need the babel helpers for?
There was a problem hiding this comment.
Local testing. This is essentially a noop in prod files.
|
@jridgewell LGTM |
ariangibson
pushed a commit
to Mixpo/amphtml
that referenced
this pull request
Sep 7, 2016
* Add Cache SW Kill File Allows setting the `cache-service-worker-kill` "experiment" config. When set, the service worker will self destruct, returning us to the dark pre-SW days. * fix presubmit
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
* Add Cache SW Kill File Allows setting the `cache-service-worker-kill` "experiment" config. When set, the service worker will self destruct, returning us to the dark pre-SW days. * fix presubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows setting the
cache-service-worker-kill"experiment" config. When set, the service worker will self destruct, returning us to the dark pre-SW days.Fixes #4649.