Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional amp-sidebar validator tests #4653

Merged
merged 1 commit into from Oct 5, 2016

Conversation

dknecht
Copy link
Contributor

@dknecht dknecht commented Aug 22, 2016

This test checks the number of children requirement

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@googlebot
Copy link

CLAs look good, thanks!

@erwinmombay
Copy link
Member

/to @powdercloud

@dknecht
Copy link
Contributor Author

dknecht commented Aug 26, 2016

@powdercloud PTAL

<p>Content</p>
</section>
<section>
<!-- Invalid example: only one child. -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this is a test for amp-accordion > section, and not all that specific to amp-sidebar.
Could this fit into here, maybe?
https://github.com/ampproject/amphtml/blob/master/extensions/amp-accordion/0.1/test/validator-amp-accordion.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will move it there.

@dknecht dknecht force-pushed the amp-sidebar-tests branch 2 times, most recently from f6e77dc to 48e2f5e Compare August 26, 2016 19:11
@dknecht
Copy link
Contributor Author

dknecht commented Oct 5, 2016

Can we merge this?

@jridgewell
Copy link
Contributor

@powdercloud?

@Gregable Gregable merged commit 3182cb8 into ampproject:master Oct 5, 2016
dreamofabear pushed a commit to dreamofabear/amphtml that referenced this pull request Oct 6, 2016
dreamofabear pushed a commit to dreamofabear/amphtml that referenced this pull request Oct 12, 2016
mityaha pushed a commit to ooyala/amphtml that referenced this pull request Nov 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants