New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional amp-sidebar validator tests #4653
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
cad7952
to
308afdf
Compare
CLAs look good, thanks! |
/to @powdercloud |
@powdercloud PTAL |
<p>Content</p> | ||
</section> | ||
<section> | ||
<!-- Invalid example: only one child. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this is a test for amp-accordion > section, and not all that specific to amp-sidebar.
Could this fit into here, maybe?
https://github.com/ampproject/amphtml/blob/master/extensions/amp-accordion/0.1/test/validator-amp-accordion.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I will move it there.
f6e77dc
to
48e2f5e
Compare
48e2f5e
to
f865c69
Compare
Can we merge this? |
This test checks the number of children requirement