Better error repoting for loadPromise fail #4800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have lots of
Error: Failed HTTP request for %s. [object HTMLImageElement]
in the log.createError
does not support interpolation so%s
was useless. Also[object HTMLImageElement]
is not very helpful.Changing to use
src
instead of the object when available, now we get:Error: Failed to load: https://cdn.ampproject.org/i/example.com/logo.jpg