Validator Updates #4909
Merged
Validator Updates #4909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Sep 16, 2016
* Polite visitors: Add Leave* methods to the RuleVisitor class. * Simplify UrlFunctionVisitor by using LeaveAtRule. * Deprecate `<amp-instagram shortcode>` and manufactured body tags. * Add a skeleton for a4a-parse-css.js. * Support `;` in splitting of properties values. * Remove the unused severity values. * Implement validateA4aCss. * Modify a4a validation rules to use `<html ⚡4ads>` or `<html amp4ads>`. * A modest refactoring that gets rid of the parsedValidatorRulesSingleton.
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
* Polite visitors: Add Leave* methods to the RuleVisitor class. * Simplify UrlFunctionVisitor by using LeaveAtRule. * Deprecate `<amp-instagram shortcode>` and manufactured body tags. * Add a skeleton for a4a-parse-css.js. * Support `;` in splitting of properties values. * Remove the unused severity values. * Implement validateA4aCss. * Modify a4a validation rules to use `<html ⚡4ads>` or `<html amp4ads>`. * A modest refactoring that gets rid of the parsedValidatorRulesSingleton.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
<html ⚡4ads>or<html amp4ads>.;in splitting of properties values.shortcodeforamp-instagram, deprecate supporting manufactured body tags