Remove dependency on httpbin.org and run local responses server #4921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
yay! no flakes! |
| @@ -22,6 +22,8 @@ import { | |||
| FetchResponse, | |||
| assertSuccess, | |||
| } from '../../src/service/xhr-impl'; | |||
| import {getCookie} from '../../src/cookies'; | |||
|
|
|||
|
|
|||
| describe('XHR', function() { | |||
There was a problem hiding this comment.
You need to rebase. I turned off these tests.
|
This is great!!! A few little comments (and the rebase and subsequent removal of the |
|
Done PTAL 👀 |
|
LGTM |
|
Merged it for you, so we get the tests back on ASAP. |
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Sep 16, 2016
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
|
@mkhatib have you considered using Sinon FakeServer? I believe launching this additional test server does add some latency. If you really need a real HTTP server for test, I think Karma custom server middleware is a better option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3101 and #4899