New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add microformats2 markup to examples folder #499

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
9 participants
@aaronpk
Contributor

aaronpk commented Oct 7, 2015

This PR adds a new example showing the same article with Microformats2 markup. You can see the parsed result in JSON format.

For more details and background on Microformats2, see the following links:

@jmadler

View changes

Show outdated Hide outdated examples/article-metadata/microformats.amp.html
@jmadler

This comment has been minimized.

Show comment
Hide comment
@jmadler

jmadler Oct 7, 2015

Contributor

Awesome! @cramforce Are you ok with including microformats2 in the spec as an acceptable structured data markup format?

Contributor

jmadler commented Oct 7, 2015

Awesome! @cramforce Are you ok with including microformats2 in the spec as an acceptable structured data markup format?

@cramforce

This comment has been minimized.

Show comment
Hide comment
@cramforce

cramforce Oct 8, 2015

Member

Could you squash your commit?

Not sure this really needs an example file yet.

CC @danbri

Member

cramforce commented Oct 8, 2015

Could you squash your commit?

Not sure this really needs an example file yet.

CC @danbri

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Oct 8, 2015

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

googlebot commented Oct 8, 2015

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot

This comment has been minimized.

Show comment
Hide comment
@googlebot

googlebot Oct 8, 2015

CLAs look good, thanks!

googlebot commented Oct 8, 2015

CLAs look good, thanks!

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Oct 8, 2015

Contributor

Is anyone consuming microformats-2 yet, at scale?

Contributor

danbri commented Oct 8, 2015

Is anyone consuming microformats-2 yet, at scale?

@aaronpk

This comment has been minimized.

Show comment
Hide comment
@aaronpk

aaronpk Oct 8, 2015

Contributor

@cramforce I just updated the PR to include just one commit.

@danbri The largest producer of microformats2 is probably https://www.brid.gy right now. Bridgy is used to send comments from Facebook, Twitter and other silos to websites that consume Microformats2, which it does by creating an h-entry page for each Tweet, Facebook comment, Flickr comment, etc.

There are user stats at the bottom of the Bridgy home page. Across 2,394 users there have been over 2 million h-entry pages consumed. These were of course consumed by many different implementations rather than a single service, so that fits at least one definition of "scale".

Contributor

aaronpk commented Oct 8, 2015

@cramforce I just updated the PR to include just one commit.

@danbri The largest producer of microformats2 is probably https://www.brid.gy right now. Bridgy is used to send comments from Facebook, Twitter and other silos to websites that consume Microformats2, which it does by creating an h-entry page for each Tweet, Facebook comment, Flickr comment, etc.

There are user stats at the bottom of the Bridgy home page. Across 2,394 users there have been over 2 million h-entry pages consumed. These were of course consumed by many different implementations rather than a single service, so that fits at least one definition of "scale".

@danbri

This comment has been minimized.

Show comment
Hide comment
@danbri

danbri Oct 8, 2015

Contributor

Thanks @aaronpk. I was asking more about the consumption side; I guess brid.gy is a little of both, since it consumes non-microformats2 from Facebook/Twitter/etc., and publishes it to other sites. Are there substantial sites that consumer microformats2 data natively?

Contributor

danbri commented Oct 8, 2015

Thanks @aaronpk. I was asking more about the consumption side; I guess brid.gy is a little of both, since it consumes non-microformats2 from Facebook/Twitter/etc., and publishes it to other sites. Are there substantial sites that consumer microformats2 data natively?

@kevinmarks

This comment has been minimized.

Show comment
Hide comment
@kevinmarks

kevinmarks Oct 8, 2015

Are there any sites that consume json-ld or microdata natively?

kevinmarks commented Oct 8, 2015

Are there any sites that consume json-ld or microdata natively?

@aaronpk

This comment has been minimized.

Show comment
Hide comment
@aaronpk

aaronpk Oct 8, 2015

Contributor

Probably the largest single consumer of microformats2 right now is http://withknown.com. Their comments are powered by microformats2 and webmention.

There is also a wordpress plugin that consumes microformats2 for comments, although I don't know how many sites it is deployed on obviously.

Contributor

aaronpk commented Oct 8, 2015

Probably the largest single consumer of microformats2 right now is http://withknown.com. Their comments are powered by microformats2 and webmention.

There is also a wordpress plugin that consumes microformats2 for comments, although I don't know how many sites it is deployed on obviously.

@erwinmombay

This comment has been minimized.

Show comment
Hide comment
@erwinmombay

erwinmombay Oct 9, 2015

Member

@aaronpk mind rebasing and pushing again. thanks

Member

erwinmombay commented Oct 9, 2015

@aaronpk mind rebasing and pushing again. thanks

@aaronpk

This comment has been minimized.

Show comment
Hide comment
@aaronpk

aaronpk Oct 9, 2015

Contributor

Sure thing!

Contributor

aaronpk commented Oct 9, 2015

Sure thing!

@erwinmombay

This comment has been minimized.

Show comment
Hide comment
@erwinmombay

erwinmombay Oct 9, 2015

Member

@aaronpk appreciate it :) CI is green now too. apologies for the flaky tests :(

Member

erwinmombay commented Oct 9, 2015

@aaronpk appreciate it :) CI is green now too. apologies for the flaky tests :(

@cramforce

This comment has been minimized.

Show comment
Hide comment
@cramforce

cramforce Oct 13, 2015

Member

TBH I'd much rather just delete all these examples. AMP doesn't really care about how docs are marked up. In any case we'd only would want to demonstrate the most popular ones.

I will also remove almost the entirety of the schema.org requirements from the spec, but I will keeo the requirement to state the type of the page, because that will be very useful in the future to get rid of AMP :)

Member

cramforce commented Oct 13, 2015

TBH I'd much rather just delete all these examples. AMP doesn't really care about how docs are marked up. In any case we'd only would want to demonstrate the most popular ones.

I will also remove almost the entirety of the schema.org requirements from the spec, but I will keeo the requirement to state the type of the page, because that will be very useful in the future to get rid of AMP :)

@amplesample

This comment has been minimized.

Show comment
Hide comment
@amplesample

amplesample Oct 13, 2015

Contributor

I think we should only support microdata and JSON-LD. Microformats are an older format, and it doesn't make sense to use these for AMP.

Contributor

amplesample commented Oct 13, 2015

I think we should only support microdata and JSON-LD. Microformats are an older format, and it doesn't make sense to use these for AMP.

@aaronpk

This comment has been minimized.

Show comment
Hide comment
@aaronpk

aaronpk Oct 13, 2015

Contributor

I am not sure the comment above is helpful. This account was opened less than a month ago, has no followers and no following/starred repos, no repos of their own, and the only recent public activity is this comment.

image

Additionally, the statement is based on out of date information. Microformats2 is the update to Microformats1, and has been developed taking into account the lessons learned and features used in practice from both microdata and RDFa, which is documented here: http://microformats.org/wiki/microformats2

Contributor

aaronpk commented Oct 13, 2015

I am not sure the comment above is helpful. This account was opened less than a month ago, has no followers and no following/starred repos, no repos of their own, and the only recent public activity is this comment.

image

Additionally, the statement is based on out of date information. Microformats2 is the update to Microformats1, and has been developed taking into account the lessons learned and features used in practice from both microdata and RDFa, which is documented here: http://microformats.org/wiki/microformats2

@cramforce

This comment has been minimized.

Show comment
Hide comment
@cramforce

cramforce Oct 13, 2015

Member

@aaronpk Please refrain from personal attacks on this Github project.

We decided to remove metadata requirements from AMP. See #593

We will rework examples to a single "common practice" example that has metadata markup that would be commonly used by a publisher in late 2015.

Member

cramforce commented Oct 13, 2015

@aaronpk Please refrain from personal attacks on this Github project.

We decided to remove metadata requirements from AMP. See #593

We will rework examples to a single "common practice" example that has metadata markup that would be commonly used by a publisher in late 2015.

@cramforce cramforce closed this Oct 13, 2015

@kevinmarks

This comment has been minimized.

Show comment
Hide comment
@kevinmarks

kevinmarks Oct 13, 2015

You know what would be great to determine common practice? Re-running something like Hixie's Web Authoring Stats survey from a decade ago:

https://web.archive.org/web/20080729053114/http://code.google.com/webstats/index.html

kevinmarks commented Oct 13, 2015

You know what would be great to determine common practice? Re-running something like Hixie's Web Authoring Stats survey from a decade ago:

https://web.archive.org/web/20080729053114/http://code.google.com/webstats/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment