Video - Bail out if viewer is not visible

[aghassemi]

No description provided.

[cramforce]

I'd consider not using an instance var for rarely used services.

[aghassemi]

viewer.isVisible() can be called several times per video, might be worth caching a reference here.

[cramforce]

The call is super fast. Not worth caching except for stuff like animations
where you call all the time.

On Wed, Sep 14, 2016 at 2:51 PM, Ali Ghassemi notifications@github.com
wrote:

@aghassemi commented on this pull request.

In src/service/video-manager-impl.js
#4995:

 this.vsync_ = vsyncFor(win);

• /** @Private @const {!../service/viewer-impl.Viewer} */
• this.viewer_ = viewerFor(win);

viewer.isVisible() can be called several times per video, might be worth
caching a reference here.

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#4995, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAFeT9NGlz9Q_5KF5Vcb7ubxyj7NOXdoks5qqGxrgaJpZM4J9DLU
.

[aghassemi]

Done

[aghassemi]

ugh, still can't merge. Can you merge this @cramforce ?