Check the --format and --html_format command line arguments. #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sadly the commander module isn't doing this, and it can lead to confusing behavior to have these flags set to something that's not supported.
|
lgtm |
honeybadgerdontcare
approved these changes
Sep 24, 2016
|
is it time to get rid of lgtm from labels? or can this new/ugly review system do it for us? |
samiamorwas
pushed a commit
to samiamorwas/amphtml
that referenced
this pull request
Sep 28, 2016
* master: (59 commits) remove toggleExperiment (ampproject#5192) Validator Updates (ampproject#5274) Update amp-form docs to document custom validations. (ampproject#5270) cron job from @erwinmombay to update size.txt (ampproject#5272) Attempt to move execution of gulp tasks into script. (ampproject#5157) Require a button instead of a link for better accessibility by default. (ampproject#5255) Fix URL Replacements bug (ampproject#5201) Remove the no longer used gladeExp param. (ampproject#5119) Add common case variant of x-ua-compatible in validator (ampproject#5163) Corrected code block rendering (ampproject#5237) Bump `amp-slidescroll` 100% on prod. (ampproject#5253) version bump / relnotes for amphtml-validator NPM release (ampproject#5252) Assert that a node is in DOM before ampdoc can be queried (ampproject#5242) Prefix transform in viewer.html to fix example on older iOS devices. (ampproject#5251) Support amp-ad for LOKA Research.inc (ampproject#4832) <amp-video> Switching from `canplay` to `loadstart` event (ampproject#5228) Viewport migrated to ampdoc scope (ampproject#5182) AMP and Yandex.Metrica (ampproject#4565) Exposing amp-lite in getMode and not autoplaying videos in lite mode (ampproject#5180) Check the --format and --html_format command line arguments. (ampproject#5215) ...
mityaha
pushed a commit
to ooyala/amphtml
that referenced
this pull request
Nov 30, 2016
…ect#5215) Sadly the commander module isn't doing this, and it can lead to confusing behavior to have these flags set to something that's not supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sadly the commander module isn't doing this, and it can lead
to confusing behavior to have these flags set to something
that's not supported.