mediaimpact: startRender API #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adtechnology could you fix the linter error so I can merge for you? |
|
@adtechnology some more linter errors :-) FYI, you can run lint locally: |
|
F**K, it was linted already, but I pasted your line from #5333 and not linted afterwards... |
adtechnology
force-pushed
the
mediaimpact
branch
from
d14f73f
to
0837cdb
Compare
|
@adtechnology there are still type check errors. Could you fix? |
adtechnology
force-pushed
the
mediaimpact
branch
2 times, most recently
from
8826cbe
to
edcc347
Compare
lannka
requested changes
Oct 10, 2016
| /* eslint google-camelcase/google-camelcase: 0 */ | ||
| global.sas_loadHandler = function(f) { | ||
| if (f.hasAd) { | ||
| f.crea || (f.crea1 = { |
There was a problem hiding this comment.
just want to make sure this is not a typo here. should it be f.crea or f.crea1?
added loadHandler functionality to support startRender API changed lib file url changed prefetch and extended preconnect settings
adtechnology
force-pushed
the
mediaimpact
branch
from
edcc347
to
bdce2e6
Compare
lannka
approved these changes
Oct 11, 2016
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Oct 12, 2016
added loadHandler functionality to support startRender API changed lib file url changed prefetch and extended preconnect settings
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
added loadHandler functionality to support startRender API changed lib file url changed prefetch and extended preconnect settings
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
added loadHandler functionality to support startRender API changed lib file url changed prefetch and extended preconnect settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added loadHandler functionality to support startRender API
changed lib file url
changed prefetch and extended preconnect settings