New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lightbox 2.0: Use object-fit:cover for thumbnails #5458

Merged

aghassemi merged 1 commit into ampproject:master from aghassemi:lightbox-cover

Oct 7, 2016

Contributor

aghassemi commented Oct 7, 2016

Before:

After:


          Use object-fit:cover for thumbnails

aghassemi added the NEEDS REVIEW label

aghassemi assigned zhouyx

zhouyx approved these changes

View reviewed changes

Contributor

zhouyx commented Oct 7, 2016 •

edited

yeah, the second one do look better besides the image gets cropped. but i guess it's fine for thumbnails.
LGTM

zhouyx added LGTM and removed NEEDS REVIEW labels

aghassemi merged commit 4ebac68 into ampproject:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment