Do not use AMP Version as RTV Versions #5474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
force-pushed
the
amp-rtv-version-script-path
branch
from
80dd5d9
to
6647f57
Compare
cramforce
reviewed
Oct 8, 2016
| @@ -177,8 +177,7 @@ export function warmupStatic(win) { | |||
| const linkRel = /*OK*/document.createElement('link'); | |||
| linkRel.rel = 'preload'; | |||
| linkRel.setAttribute('as', 'script'); | |||
| linkRel.href = | |||
| `${urls.cdn}/rtv/01$internalRuntimeVersion$/v0.js`; | |||
| linkRel.href = `${urls.cdn}/v0.js`; | |||
There was a problem hiding this comment.
@erwinmombay Do we inject the config yet? In any way we should.
There was a problem hiding this comment.
@cramforce is this code part of alp.js? if so then yes:
cramforce
approved these changes
Oct 8, 2016
cramforce
approved these changes
Oct 10, 2016
| @@ -177,8 +177,7 @@ export function warmupStatic(win) { | |||
| const linkRel = /*OK*/document.createElement('link'); | |||
| linkRel.rel = 'preload'; | |||
| linkRel.setAttribute('as', 'script'); | |||
| linkRel.href = | |||
| `${urls.cdn}/rtv/01$internalRuntimeVersion$/v0.js`; | |||
| linkRel.href = `${urls.cdn}/v0.js`; | |||
jridgewell
force-pushed
the
amp-rtv-version-script-path
branch
from
70d82b3
to
17a729f
Compare
samiamorwas
pushed a commit
to samiamorwas/amphtml
that referenced
this pull request
Oct 18, 2016
…mp_reddit_extension * 'master' of https://github.com/ampproject/amphtml: (63 commits) Position:relative on body (ampproject#5665) Fix for ampproject#5663 (ampproject#5664) Nokta Ad Server is added as an ad type (ampproject#5550) RFC: Separate the load phase of AMP into multiple chunks. (ampproject#5536) Add OWNERS files for A4A. (ampproject#5651) Update DEVELOPING.md Call original event add/remove via interceptor (ampproject#5650) Fix wording on confusing steps to protect against CSRF. (ampproject#5646) Install runtime CSS for all amp tests (ampproject#5642) Implement outgoing link URL replacements. (ampproject#5628) Wait for window to load before installing ServiceWorker. (ampproject#5638) iOS wrapper viewport implementation (ampproject#5629) Do not use AMP Version as RTV Versions (ampproject#5474) Purch Ad Support for Amp-Ads (ampproject#5464) A11Y fix for sticky ad close button. (ampproject#5640) Propagate ARIA attributes to real-elements (ampproject#5590) Ibillboard integration (ampproject#5392) Add some keywords to the NPM description of the validator. (ampproject#5633) PWA: messaging and broadcast (ampproject#5588) Carousel swipe not working well on Android Firefox (ampproject#5626) ...
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Do not use AMP Version as RTV Versions Fixes ampproject#5471. * Fix tests
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Do not use AMP Version as RTV Versions Fixes ampproject#5471. * Fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5471. #5471 is invalid:
The core issue is that the Cache SW will serve stale-while-revalidate serve last week's (let's call it
v1) AMP version, but that request will still look like it's requesting the newest AMP version (v2). The runtime will then dynamically inject the<amp-ad>'s script url using its AMP version (v1, notv2), so it'll look like we've been servedv2scripts but then requested thev1<amp-ad>.