Sharethrough render-start support added

[peterkinmond]

Hi, we've added the "renderStart" and "noContentAvailable" methods (refer to #5234).
Could you please review?

Thanks!

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[jridgewell]

/to @lannka

[peterkinmond]

We signed the Google CLA on behalf of my company Sharethrough and it should be under their name.

[lannka]

CLA: Sharethrough

[lannka]

@peterkinmond I don't see ad loaded in ads.amp.html. It timed out and fallback to "no ad". Did you try to correctly call renderStart in your SDK?

Please take a look at the developer guidelines and try to make it work locally.

[lannka]

CLA robot didn't recognize. Maybe try to mention your corp again?

[jridgewell]

@peterkinmond: When using a Corp CLA, you have to author commits using a corp email address (@sharethrough.com).

[lannka]

When using a Corp CLA, you have to author commits using a corp email address (@sharethrough.com).

@jridgewell oh that's the trick? I have no idea what happened in signing corp CLA, does Google collect the corp email domain?

[jridgewell]

I think so.

[peterkinmond]

@jridgewell Is needing a corp email address a new rule? I'm a member of the Sharethrough org on Github and last time we added to AMP project it wasn't with a corp email address.

[peterkinmond]

@lannka Thanks for the quick response in testing out the PR. I see a Sharethrough ad loading consistently on http://localhost:8000/examples/ads.amp.max.html when running it locally on my machine. I looked through the developer guidelines you linked to and everything seems to be correct. Is there something else I can do to confirm it's working correctly?

[lannka]

Would that be because of any ad targeting so we fall into different loading path?

[peterkinmond]

@lannka Ok we've made an update on our side which should now fix it and fire the events correctly. Can you try again?

[lannka]

It works now.

@cramforce could you please force merge. We have CLA problem again.

[cramforce]

Happy to :)

[peterkinmond]

Thanks!