Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set aria-expanded on accordion controls, not content #5577

Merged
merged 2 commits into from
Oct 13, 2016
Merged

Set aria-expanded on accordion controls, not content #5577

merged 2 commits into from
Oct 13, 2016

Conversation

dvoytenko
Copy link
Contributor

Closes #5488.

aghassemi
aghassemi approved these changes Oct 13, 2016
View reviewed changes
Copy link
Contributor

@aghassemi aghassemi left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just lint and good to go. You win first a11y PR! (Prize is an AMP laptop sticker)

@dvoytenko dvoytenko merged commit 5ba9531 into ampproject:master Oct 13, 2016
@dvoytenko dvoytenko deleted the fixes92 branch October 13, 2016 20:18
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Set aria-expanded on accordion controls, not content (ampproject#5577)
759afb5 
* Set aria-expanded on accordion controls, not content

* tests
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Set aria-expanded on accordion controls, not content (ampproject#5577)
dc8d41e 
* Set aria-expanded on accordion controls, not content

* tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aghassemi aghassemi aghassemi approved these changes

Assignees

@aghassemi aghassemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dvoytenko @aghassemi