[A11Y] amp-image-lightbox set aria attributes #5579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
suggested changes
Oct 13, 2016
| @@ -92,6 +92,14 @@ export class ImageViewer { | |||
| /** @private {?../../../src/srcset.Srcset} */ | |||
| this.srcset_ = null; | |||
|
|
|||
| /** @private {!Object} */ | |||
| this.captions_ = { | |||
| @@ -223,10 +235,22 @@ export class ImageViewer { | |||
| this.sourceWidth_ = sourceElement./*OK*/offsetWidth; | |||
| this.sourceHeight_ = sourceElement./*OK*/offsetHeight; | |||
| this.srcset_ = srcsetFromElement(sourceElement); | |||
| Object.keys(this.captions_).forEach(key => { | |||
| if (key == 'aria-describedby') { | |||
There was a problem hiding this comment.
I would turn aria-describedby around and have AmpImageLightbox handle it instead of ImageViewer since it is not really a cloned attribute like aria-label it.
Essentially, what I am recommending is to have
AmpImageLightbox call getImage() on the ImageViewer and set the aria-describedby on init_ to the id it has and remove it on reset_ (so ImageViewer has no idea of the id of the caption which is part of the AmpImageLightbox and captionElement can go back to being private.
| /** @private {?Element} */ | ||
| this.captionElement_ = null; | ||
| /** {?Element} */ | ||
| this.captionElement = null; |
There was a problem hiding this comment.
see previous comment, we should keep this private.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5501 and #5502