Validator Changes Rollup #5596
Merged
Validator Changes Rollup #5596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeybadgerdontcare
approved these changes
Oct 13, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Remove repeated `layout` attribute in `<amp-social-share>` example. * Allow custom validation attributes in forms. * Validate that submit-success/submit-error have templates. * Extract mapped attribute values in reverse order. * Allow AttrTriggerSpec to trigger when if_value_regex is not set. * Validator rules for `<amp-app-banner>` * Comment cleanup. * Handle non-quoted attribute values containing quotation characters. * Allow links to have target=_top. * Allow input and label without a form ancestor. * Add a value_casei option to AttrSpec
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Remove repeated `layout` attribute in `<amp-social-share>` example. * Allow custom validation attributes in forms. * Validate that submit-success/submit-error have templates. * Extract mapped attribute values in reverse order. * Allow AttrTriggerSpec to trigger when if_value_regex is not set. * Validator rules for `<amp-app-banner>` * Comment cleanup. * Handle non-quoted attribute values containing quotation characters. * Allow links to have target=_top. * Allow input and label without a form ancestor. * Add a value_casei option to AttrSpec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<amp-app-banner>