Better document Actions and Events in AMP #5648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkhatib
commented
Oct 17, 2016
| @@ -192,7 +192,7 @@ HTML tags can be used unchanged in AMP HTML. Certain tags have equivalent custom | |||
| </tr> | |||
| <tr> | |||
| <td width="30%"><code><a name="ancr"></a>a</code></td> | |||
| <td>The <code>href</code> attribute value must not begin with <code>javascript:</code>. If set, the <code>target</code> attribute value must be <code>_blank</code>. Otherwise allowed. <a href="#ancr">🔗</a></td> | |||
| <td>The <code>href</code> attribute value must not begin with <code>javascript:</code>. If set, the <code>target</code> attribute value must be <code>_blank</code> or `_top`. Otherwise allowed. <a href="#ancr">🔗</a></td> | |||
There was a problem hiding this comment.
@cramforce is it ok to update this already?
There was a problem hiding this comment.
I don't think it is rolled out yet, but @Gregable would know.
| <td>Opens the image lightbox with the source image being the one that triggered the action.</td> | ||
| </tr> | ||
| </table> | ||
|
|
There was a problem hiding this comment.
i think it would be useful to provide how to use examples here.
|
@camelburrito 👀 PTAL |
| </tr> | ||
| <tr> | ||
| <td width="30%">input elements</td> | ||
| <td>Prohibited. Includes <code>input</code>, <code>textarea</code>, <code>select</code>, <code>option</code>. Notably, the <code>button</code> element is allowed.</td> | ||
| <td>Mostly Allowed with exception of some input types, namely, `input[type=image]`, `input[type=button]`, `input[type=password]`, `input[type=file]` are invalid. Related tags are also allowed: `fieldset`, `label`</td> |
There was a problem hiding this comment.
exception of some input types - link it to the right section in form.md
camelburrito
approved these changes
Oct 19, 2016
mkhatib
force-pushed
the
actions-events-spec
branch
from
1315eaa
to
e5e1906
Compare
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5641 and #5617