Fix url rewritting to new version #5669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
approved these changes
Oct 18, 2016
| expect(sw.rtvVersion(prefixless)).to.equal(`01${version}`); | ||
| describe('with RTV versioned file', () => { | ||
| const v0 = `https://cdn.ampproject.org/rtv/${rtv}/v0.js`; | ||
| const v1 = v0.replace('v0', 'v1'); |
There was a problem hiding this comment.
Please hardcode the full strings. That is easier to read.
There was a problem hiding this comment.
Great suggestion, done.
Makes things MUCH clearer.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Fix url rewritting to new version Fixes ampproject#5575. * Use hardcoded urls Makes things MUCH clearer.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Fix url rewritting to new version Fixes ampproject#5575. * Use hardcoded urls Makes things MUCH clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were rewriting requests like so:
/v0/amp-comp.js->rtv/123/amp-comp.jsrtv/100/v0/amp-comp.js->rtv/123/amp-comp.jsNotice that the rewrites have dropped the
v0/directory. Doh!I've also added tests so that
v1requests will work (whenever we release one).Fixes #5575.