Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix English, uniform capitalization, better changelog #5842

Merged
merged 1 commit into from Oct 27, 2016
Merged

Fix English, uniform capitalization, better changelog #5842

merged 1 commit into from Oct 27, 2016

Conversation

dandv
Copy link
Contributor

@dandv dandv commented Oct 26, 2016

  • consistent capitalization of "Reader", "Publisher"
  • consistent smart single quotes
  • sort changelog by date and add year to timestamps
  • fix link to ExternalCID
  • add READER_ID example

@jridgewell
Copy link
Contributor

/to @bpaduch

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates and corrections. Regarding the capitalization of "Publisher" and "Reader", I believe that to be unnecessary as they aren't proper nouns, nor are we referring to a GUI element or code element (e.g., "Reader ID" would remain capitalized as it refers to a field/code element). I do agree that capitalization should be consistent throughout the doc, so perhaps, undo this capitalization and fix the previous capitalization issues.

@dandv
Copy link
Contributor Author

dandv commented Oct 27, 2016

Regarding the capitalization of "Publisher" and "Reader", I believe that to be unnecessary as they aren't proper nouns

Agree. I had just adopted the prevalent convention - Reader and Publisher were capitalized in about 75% of the instances. There are words subject to this pattern, such as "The AMP Runtime calls the Authorization endpoint" or "restricted sections based on the Authorization response", "Pingback endpoint and Login Page are optional" etc.

Would it make sense to merge this PR, then do another sweep for all capitalization issues?

@ghost
Copy link

ghost commented Oct 27, 2016

Sure, sounds good.

@jridgewell jridgewell merged commit 399cac4 into ampproject:master Oct 27, 2016
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants