Run Travis tests on latest Chrome (not Chromium) #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
changed the title
|
/cc @erwinmombay |
|
Now there are 3 failing tests ( same as local, Yay! ). The form ones are fixed in #5835 I am looking at |
|
If Chrome is available that is definitely better! |
|
@cramforce This will download and install the latest "stable" Chrome. (adds a few seconds to the whole thing but worth it IMO) After #5847 and #5835 are merged, all tests should pass and we can switch to this new setup for Travis. |
|
SG. Glad this is now possible on Travis. |
jridgewell
approved these changes
Oct 27, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.