call viewport.updateFixedLayer when we display amp-live-list update button #5865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
force-pushed
the
amp-live-list-fixed-layer
branch
from
bc2b395
to
71e6be5
Compare
|
@ericlindley-g will leave it up to you how much priority it is to get the fix into prod. right now it will take 2 weeks (since this wont go into canary until next week) |
|
Thanks — @erwinmombay, is this an issue for for all iOS browser/device combos? Do you know roughly how long this has been an issue? |
|
@ericlindley-g i think its been there from the start or when they switched from padding to border to compensate for the header. not sure |
|
@muxin can you remember when we switched from padding to border? |
dvoytenko
approved these changes
Oct 27, 2016
|
LGTM |
|
@erwinmombay For android, we always use padding. For IOS, we switch from padding to border in Feb |
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
livelist update button was not visible on ios as it is hidden by viewer header
/to @dvoytenko