Clean up: Move viewport specific logic out from viewer. #5887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
reviewed
Oct 28, 2016
| let viewportType = viewer.getParam('viewportType') || ViewportType.NATURAL; | ||
| if (platformFor(win).isIos() | ||
| && ((viewportType == ViewportType.NATURAL && viewer.isIframed()) | ||
| // Enable iOS Embedded mode so that it's easy to test against a more |
There was a problem hiding this comment.
Let's' move this comment to the assignment.
There was a problem hiding this comment.
the comment is specific to dev mode, so better be here
dvoytenko
approved these changes
Oct 31, 2016
lannka
added a commit
to lannka/amphtml
that referenced
this pull request
Nov 2, 2016
…: Move viewport specific logic out from viewer.)
lannka
added a commit
that referenced
this pull request
Nov 2, 2016
…ific logic out from viewer.) (#5972)
|
@lannka To confirm, did you catch up this PR to @cramforce's changes? |
|
Ugh, I didn't check for it and this PR doesn't have the extra check. Means our canary has the bad state again. @aghassemi |
|
Ok. Let's start with fixing it. @lannka Could you please send the fix? Or should we rollback? |
|
@dvoytenko false alarm. We checked master and Malte's code is there as part of #5972 |
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
…: Move viewport specific logic out from viewer.) (ampproject#5972)
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
…: Move viewport specific logic out from viewer.) (ampproject#5972)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.