A4a 3p remove load from init #5936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous change was made in error (wrong branch).
zhouyx
reviewed
Nov 1, 2016
| @@ -124,23 +132,17 @@ export class AmpAdXOriginIframeHandler { | |||
| // post message depending on if A4A flow. | |||
There was a problem hiding this comment.
let's remove the comment here.
There was a problem hiding this comment.
Done. Please merge and thanks!
zhouyx
approved these changes
Nov 2, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Update amp-ad-network-doubleclick-impl.md * Reverting doc changes The previous change was made in error (wrong branch). * Remove load listener from AmpAdXOriginIframeHandler.init * Correct conflict * PR feedback
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Update amp-ad-network-doubleclick-impl.md * Reverting doc changes The previous change was made in error (wrong branch). * Remove load listener from AmpAdXOriginIframeHandler.init * Correct conflict * PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer require load event to remove visibility hidden from frame (in fact A4A flow never sets visibility hidden)