Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More SauceLabs flake fixes #5943

Merged
merged 3 commits into from
Nov 1, 2016
Merged

More SauceLabs flake fixes #5943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c82178
Upgrade old chrome to 45
aghassemi Nov 1, 2016
21c5643
trying to fix more saucelabs flakes
aghassemi Nov 1, 2016
9384430
Merge branch 'master' of github.com:ampproject/amphtml into finalfina…
aghassemi Nov 1, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/integration/test-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ import {
expectBodyToBecomeVisible,
} from '../../testing/iframe.js';

describe.configure().retryOnSaucelabs().run('error page', () => {
describe.configure().retryOnSaucelabs().run('error page', function() {
this.timeout(5000);
let fixture;
beforeEach(() => {
return createFixtureIframe('test/fixtures/errors.html', 500, win => {
return createFixtureIframe('test/fixtures/errors.html', 1000, win => {
// Trigger dev mode.
try {
win.history.pushState({}, '', 'test2.html#development=1');
Expand Down
3 changes: 2 additions & 1 deletion test/integration/test-video-players-helper.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,8 @@ import {
export function runVideoPlayerIntegrationTests(createVideoElementFunc) {

const TIMEOUT = 20000;
it('should override the video interface methods', function() {
it.configure().retryOnSaucelabs()
.run('should override the video interface methods', function() {
this.timeout(TIMEOUT);
return getVideoPlayer(/* opt_outsideView */ false)
.then(v => {
Expand Down