New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the auto generated AMP element ID. #6132
Conversation
@@ -342,9 +342,6 @@ export class Resources { | |||
|
|||
// Create and add the resource. | |||
const resource = new Resource((++this.resourceIdCounter_), element, this); | |||
if (!element.id) { | |||
element.id = 'AMP_' + resource.getId(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be useful to keep in dev mode. I remember chatting about this with @dvoytenko
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we now can get it from element.getResourceId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Closes #6000