Force transfer sidebar to the Fixed 'transfer' layer. #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
approved these changes
Nov 11, 2016
| @@ -168,7 +168,7 @@ export class AmpSidebar extends AMP.BaseElement { | |||
| this.viewport_.disableTouchZoom(); | |||
| this.vsync_.mutate(() => { | |||
| toggle(this.element, /* display */true); | |||
| this.viewport_.addToFixedLayer(this.element); | |||
| this.viewport_.addToFixedLayer(this.element, /*forceTransfer*/ true); | |||
There was a problem hiding this comment.
nit: spaces inside the /**/
|
@dvoytenko - this is not performing too well with animations - ill have to re-think this. |
|
@camelburrito This probably simple means that we'll have to split |
|
i tried that already , the animation is stuttering and not looking very good. |
|
@camelburrito If animation is stuttering, that simply means that we need to separate layout changes with animation run. 1 or 2 animation frames would do it. |
camelburrito
force-pushed
the
sidebar
branch
from
798e358
to
1122b49
Compare
|
@dvoytenko could you take another look. I made a minor change in fixed-layer |
camelburrito
force-pushed
the
sidebar
branch
from
1122b49
to
ce9da15
Compare
dvoytenko
reviewed
Nov 22, 2016
| @@ -307,7 +313,7 @@ export class FixedLayer { | |||
| // `height` is constrained to at most 300px. This is to avoid | |||
| // transfering of more substantial sections for now. Likely to be | |||
| // relaxed in the future. | |||
| const isTransferrable = ( | |||
| const isTransferrable = fe.forceTransfer || ( | |||
There was a problem hiding this comment.
Since you added forceTransfer already in isFixed, you should defer to isFixed here. E.g. it should likely look like:
const isTransferrable = isFixed && (
fe.forceTransfer || (opacity > 0 && ...)
);
dvoytenko
approved these changes
Nov 22, 2016
camelburrito
force-pushed
the
sidebar
branch
from
ce9da15
to
c7c36be
Compare
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Force transfer sidebar to the Fixed 'transfer' layer. * review fix. * Move to fixed layer before opening. * Adding to fixed layer before dp block * moving fl to build cb * Make isFixed true for forceTransferElements * Make isFixed true for forceTransferElements * Review fixes
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Force transfer sidebar to the Fixed 'transfer' layer. * review fix. * Move to fixed layer before opening. * Adding to fixed layer before dp block * moving fl to build cb * Make isFixed true for forceTransferElements * Make isFixed true for forceTransferElements * Review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes - #6045