Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a value for &jid param. #6186

Merged
merged 1 commit into from Nov 15, 2016
Merged

Add a value for &jid param. #6186

merged 1 commit into from Nov 15, 2016

Conversation

avimehta
Copy link
Contributor

Turns out, it is needed and empty value is not enough.

Turns out, it is needed and empty value is not enough for pageviews.
Rest of the hits can/should still contain an empty value.
@avimehta avimehta merged commit d613e65 into ampproject:master Nov 15, 2016
@avimehta avimehta deleted the a4a2 branch November 15, 2016 19:09
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Turns out, it is needed and empty value is not enough for pageviews.
Rest of the hits can/should still contain an empty value.
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Turns out, it is needed and empty value is not enough for pageviews.
Rest of the hits can/should still contain an empty value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants