Move the iframe's box, not the wrapping AMP Element's #6248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Imagine the iframe's box is smaller. If we moved the AMP Element's `box`, we would have the wrong `width`/`height`, because the iframe is smaller. So avoiding the allocation is the exact wrong thing to do.
zhouyx
suggested changes
Nov 19, 2016
| @@ -199,9 +199,7 @@ export class AmpAd3PImpl extends AMP.BaseElement { | |||
| if (!this.iframeLayoutBox_) { | |||
| this.measureIframeLayoutBox_(); | |||
There was a problem hiding this comment.
measureIframeLayoutBox_() returns iframe layoutRect relative to the amp-ad or amp-iframe element. However I searched our code and it seems to me the this.iframeLayoutBox_ is only used here. So instead of applying box offset and apply it back here. Why don't we just return layoutRect relative to doc in #measureIframeLayoutBox
There was a problem hiding this comment.
#5271. I should really add a test so someone doesn't "optimize" this away.
There was a problem hiding this comment.
👍
Please add a comment though. or a link to #5271.
#getIntersectionElementLayoutBox isn’t appropriate to get the bounding box.
zhouyx
approved these changes
Nov 21, 2016
These will both pass, since we're measuring the box just before.
jridgewell
force-pushed
the
fix-iframe-measurement-inob
branch
from
c17dacb
to
d1f1f4a
Compare
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Move the iframe's box, not the wrapping AMP Element's Imagine the iframe's box is smaller. If we moved the AMP Element's `box`, we would have the wrong `width`/`height`, because the iframe is smaller. So avoiding the allocation is the exact wrong thing to do. * Use CustomElement#getLayoutBox #getIntersectionElementLayoutBox isn’t appropriate to get the bounding box. * Add test cases * Assert that the intersection is not the amp-iframe's size, but the iframe's * Comments * Fix assertion * Assert truthiness to pass type check These will both pass, since we're measuring the box just before. * Fix presubmit error * Move Ad3p test into 3p tests
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Move the iframe's box, not the wrapping AMP Element's Imagine the iframe's box is smaller. If we moved the AMP Element's `box`, we would have the wrong `width`/`height`, because the iframe is smaller. So avoiding the allocation is the exact wrong thing to do. * Use CustomElement#getLayoutBox #getIntersectionElementLayoutBox isn’t appropriate to get the bounding box. * Add test cases * Assert that the intersection is not the amp-iframe's size, but the iframe's * Comments * Fix assertion * Assert truthiness to pass type check These will both pass, since we're measuring the box just before. * Fix presubmit error * Move Ad3p test into 3p tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagine the iframe's box is smaller. If we moved the AMP Element's
box, we would have the wrongwidth/height, because the iframe issmaller. So avoiding the allocation is the exact wrong thing to do.