Validator Rollup #6284
Merged
Validator Rollup #6284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om appearing after any URL on the page.
honeybadgerdontcare
approved these changes
Nov 21, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* revision bump due to amp-hulu extension * Support both v0.js and amp4ads-v0.js if the html_format is AMP4ADS * Test in javascript that validator rules should make sense. * Implement new validator logic that disallows the `<base href>` tag from appearing after any URL on the page. * Test ValidationError in javascript. * Allow this usage of startsWith to pass travis.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* revision bump due to amp-hulu extension * Support both v0.js and amp4ads-v0.js if the html_format is AMP4ADS * Test in javascript that validator rules should make sense. * Implement new validator logic that disallows the `<base href>` tag from appearing after any URL on the page. * Test ValidationError in javascript. * Allow this usage of startsWith to pass travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.