Update class/ID/tagname docs #6302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aghassemi
reviewed
Nov 22, 2016
|
|
||
| Internal AMP class names prefixed with `-amp-` and `i-amp-` are disallowed in AMP HTML. | ||
|
|
||
| Consult AMP documentation for meaning of class names prefixed `amp-`. The use of these classes is allowed and meant to allow customization of some features of AMP runtime and extensions. |
aghassemi
approved these changes
Nov 22, 2016
|
|
||
| Consult AMP documentation for specific extensions before using `amp-` and `AMP` IDs to avoid conflict with the features provided by these extensions, such as `amp-access`. | ||
|
|
||
| All other authored class names are allowed in AMP HTML markup. |
|
LGTM—thanks! |
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Update class/ID/tagname docs * review fixes
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Update class/ID/tagname docs * review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.