Expose sourceUrl to amp-ad iframe. #6371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
approved these changes
Nov 28, 2016
| @@ -51,6 +51,7 @@ We will provide the following information to the ad: | |||
| In browsers that support `location.ancestorOrigins` you can trust that the `origin` of the | |||
| location is actually correct (So rogue pages cannot claim they represent an origin they do not actually represent). | |||
| - `window.context.canonicalUrl` contains the canonical URL of the primary document as defined by its `link rel=canonical` tag. | |||
| - `window.context.sourceUrl` contains the source URL of the original AMP document. | |||
There was a problem hiding this comment.
Explain what the differenced from location.href is (Cache relationship).
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Expose sourceUrl to amp-ad iframe. * Add a link to the spec.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Expose sourceUrl to amp-ad iframe. * Add a link to the spec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6231