Use manifest and origin-manifest to look for banner source #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
approved these changes
Nov 29, 2016
| @@ -99,7 +99,7 @@ describe('amp-app-banner', () => { | |||
|
|
|||
| if (config.manifest) { | |||
| const manifest = iframe.doc.createElement('link'); | |||
| manifest.setAttribute('rel', 'amp-manifest'); | |||
| manifest.setAttribute('rel', 'manifest'); | |||
There was a problem hiding this comment.
Add a second test for origin-manifest
mkhatib
added a commit
to mkhatib/amphtml
that referenced
this pull request
Dec 1, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6387