Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom loader for <amp-apester-media> #6627

Merged
merged 1 commit into from Dec 14, 2016

Conversation

mrsufgi
Copy link
Contributor

@mrsufgi mrsufgi commented Dec 13, 2016

Hey All,

This PR exists only because I did some bad merge/rebases,
In short, this feature add custom loader into elements. (based on createPlaceholderCallback() )

hopefully, this could be merged ASAP.

@dvoytenko @OmriKeret

Best,
Ori

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@mrsufgi
Copy link
Contributor Author

mrsufgi commented Dec 13, 2016

I signed it!

@mrsufgi
Copy link
Contributor Author

mrsufgi commented Dec 13, 2016

this replace #6053.

@dvoytenko dvoytenko merged commit 6907a0f into ampproject:master Dec 14, 2016
@dvoytenko
Copy link
Contributor

@mrsufgi Merged! Thanks a lot!

Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Lith pushed a commit to Lith/amphtml that referenced this pull request Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants