Validator Rollup #6761
Merged
Validator Rollup #6761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o the tagstack object.
honeybadgerdontcare
approved these changes
Dec 20, 2016
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Revision bump for `<amp-ooyala>` * Refactoring: Move the validation procedures out of ParsedAttrSpec. * Separate the validateUrlAndProtocol routine from ParsedUrlSpec. * Add uniqueness and matching tag checks to all extensions, with a few exceptions. * Separate the validation routine from ParsedUrlSpec. * Allow anchor hrefs to be empty strings. Easy part of the github issue. * Refactoring: Move validation routines out of ParsedTagSpec class * Refactoring. Move the cdata matcher out of the context object and into the tagstack object. * Move the Parsed* classes toward the top of the file. * Combine methods into computeCssParsingConfig. * Move `<amp-ooyala-player>` to correct path. * Disallowed id and name values. * Revision bump for RDF changes. * Small changes to amp-auto-ads and amp-bind rules.
Lith
pushed a commit
to Lith/amphtml
that referenced
this pull request
Dec 22, 2016
* Revision bump for `<amp-ooyala>` * Refactoring: Move the validation procedures out of ParsedAttrSpec. * Separate the validateUrlAndProtocol routine from ParsedUrlSpec. * Add uniqueness and matching tag checks to all extensions, with a few exceptions. * Separate the validation routine from ParsedUrlSpec. * Allow anchor hrefs to be empty strings. Easy part of the github issue. * Refactoring: Move validation routines out of ParsedTagSpec class * Refactoring. Move the cdata matcher out of the context object and into the tagstack object. * Move the Parsed* classes toward the top of the file. * Combine methods into computeCssParsingConfig. * Move `<amp-ooyala-player>` to correct path. * Disallowed id and name values. * Revision bump for RDF changes. * Small changes to amp-auto-ads and amp-bind rules.
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Jan 3, 2017
* Revision bump for `<amp-ooyala>` * Refactoring: Move the validation procedures out of ParsedAttrSpec. * Separate the validateUrlAndProtocol routine from ParsedUrlSpec. * Add uniqueness and matching tag checks to all extensions, with a few exceptions. * Separate the validation routine from ParsedUrlSpec. * Allow anchor hrefs to be empty strings. Easy part of the github issue. * Refactoring: Move validation routines out of ParsedTagSpec class * Refactoring. Move the cdata matcher out of the context object and into the tagstack object. * Move the Parsed* classes toward the top of the file. * Combine methods into computeCssParsingConfig. * Move `<amp-ooyala-player>` to correct path. * Disallowed id and name values. * Revision bump for RDF changes. * Small changes to amp-auto-ads and amp-bind rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.