Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ads/README.md to inform 3P developer to add fake ad examples. #6891

Merged
merged 2 commits into from Jan 5, 2017
Merged

Update ads/README.md to inform 3P developer to add fake ad examples. #6891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47c46e7
Update ads/README.md to inform 3P developer to add fake ad examples.
lannka Jan 5, 2017
869038b
Update ads/README.md to inform 3P developer to add fake ad examples.
lannka Jan 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ads/README.md
View file
Open in desktop
Expand Up @@ -226,7 +226,7 @@ If you're adding support for a new 3P ad service, changes to the following files
- `/ads/_config.js` - add service specific configuration here.
- `/3p/integration.js` - register your service here.
- `/extensions/amp-ad/amp-ad.md` - add a link that points to your publisher doc.
- `/examples/ads.amp.html` - add publisher examples here.
- `/examples/ads.amp.html` - add publisher examples here. Since real ad isn't guaranteed to fill, a consistently displayed fake ad is highly recommended here to help AMP developers confidently identify new bugs.

### Verify your examples

Expand Down