Kiosked ads #7049
Kiosked ads #7049
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
signed it
|
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
CLAs look good, thanks! |
|
/to @lannka |
|
@EdvardKarvinen would you try to follow the guide and implement the render-start API? |
|
@lannka render-start implemented |
| if (data.hasOwnProperty('scriptid')) { | ||
| scriptId = data['scriptid']; | ||
| } | ||
| window.addEventListener('kioskedAdRender', function() { |
There was a problem hiding this comment.
should be able to do
window.addEventListener('kioskedAdRender', global.context.renderStart, false)
There was a problem hiding this comment.
If i do that, it will give an error:
Uncaught DOMException: Failed to execute 'postMessage' on 'Window': An object could not be cloned.
| global.context.noContentAvailable(); | ||
| }, false); | ||
|
|
||
| writeScript(global, 'https://scripts.kiosked.com/loader/kiosked-ad.js?staticTagId=' + scriptId); |
There was a problem hiding this comment.
you can take advantage of preconnect in config
There was a problem hiding this comment.
how can I preconnect in config file if URL needs scriptId parameter?
examples/ads.amp.html
Outdated
| @@ -787,6 +789,14 @@ <h2 id="kargo">Kargo</h2> | |||
| <div fallback></div> | |||
| </amp-ad> | |||
|
|
|||
| <h2 id="kiosked">Kiosked</h2> | |||
| <amp-ad width="300" height="250" | |||
| type="kiosked" | |||
There was a problem hiding this comment.
Fixed and commited
|
Ping @lannka. |
* Kiosked ads * Indentation fix * lint error fix * lint error fix * lint error fix * ads.amp.html script fix * readme file change * implemented renderStart API for Kiosked plugin * indentation changes
Ads extension to show ads from Kiosked