Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an extra check for checkValidity on the element #7126

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Add an extra check for checkValidity on the element #7126

merged 1 commit into from
Jan 23, 2017

Conversation

mkhatib
Copy link
Contributor

@mkhatib mkhatib commented Jan 20, 2017

Fixes console errors when amp-selector is used.

camelburrito
camelburrito approved these changes Jan 20, 2017
View reviewed changes
Copy link
Contributor

@camelburrito camelburrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can get

@mkhatib mkhatib merged commit a77c434 into ampproject:master Jan 23, 2017
@mkhatib mkhatib deleted the check-validity-check branch January 23, 2017 23:30
jridgewell pushed a commit to jridgewell/amphtml that referenced this pull request Jan 31, 2017
@mkhatib @jridgewell
Add an extra check for checkValidity on the element. (ampproject#7126)
d342c55
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
@mkhatib @mrjoro
Add an extra check for checkValidity on the element. (ampproject#7126)
f02d7b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelburrito camelburrito camelburrito approved these changes

Assignees

@camelburrito camelburrito

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mkhatib @camelburrito