Make fetch "normal" #7138
Merged
Make fetch "normal" #7138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
added a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 20, 2017
Part 2 to fixing ampproject#7119 ([Part 1](ampproject#7138)).
jridgewell
force-pushed
the
xhr-refactor
branch
from
16e6c6f
to
f58749e
Compare
jridgewell
force-pushed
the
xhr-refactor
branch
2 times, most recently
from
188b78c
to
030db8b
Compare
dvoytenko
approved these changes
Jan 24, 2017
test/functional/test-xhr.js
Outdated
| @@ -529,7 +529,7 @@ describe('XHR', function() { | |||
| }); | |||
|
|
|||
| describe('#fetch ' + test.desc, () => { | |||
| const creative = '<html><body>This is a creative</body></html>'; | |||
| const creative = '<html><body>This is a creative💩</body></html>'; | |||
jridgewell
force-pushed
the
xhr-refactor
branch
from
e01a05d
to
fc8c466
Compare
jridgewell
added a commit
that referenced
this pull request
Feb 1, 2017
…uffer. (ampproject#7133)" This reverts commit 27d6886.
Makes fetch a normal implementation. We implement `#arrayBuffer` by way of `utf8EncodeSync`, like it should have been.
jridgewell
force-pushed
the
xhr-refactor
branch
from
fc8c466
to
5150d56
Compare
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
Part 2 to fixing ampproject#7119 ([Part 1](ampproject#7138)).
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
* Revert "Use proper application/json response header instead of arraybuffer. (ampproject#7133)" This reverts commit 27d6886. * Make fetch "normal" Makes fetch a normal implementation. We implement `#arrayBuffer` by way of `utf8EncodeSync`, like it should have been. * Fix types * Test UTF8 in XHR's ArrayBuffer * Remove final uses of fetchJsonResponse
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Part 2 to fixing ampproject#7119 ([Part 1](ampproject#7138)).
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Revert "Use proper application/json response header instead of arraybuffer. (ampproject#7133)" This reverts commit 27d6886. * Make fetch "normal" Makes fetch a normal implementation. We implement `#arrayBuffer` by way of `utf8EncodeSync`, like it should have been. * Fix types * Test UTF8 in XHR's ArrayBuffer * Remove final uses of fetchJsonResponse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes fetch a normal implementation. We implement
#arrayBufferby wayof
utf8EncodeSync, like it should have been.Part 1 to fixing #7119.