Extract signals into its own class #7240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
approved these changes
Jan 28, 2017
| * This object tracts signals and allows blocking until a signal has been | ||
| * received. | ||
| */ | ||
| export class Signals { |
There was a problem hiding this comment.
An extra object allocation per element.
There was a problem hiding this comment.
This is the cost of being able to track past events that maybe requested in the future. Can't see another option, tbh. But would be happy to discuss.
|
This is fine. Do we currently need signals on all elements? Or could elements opt-in? |
|
@cramforce We are now using it for built signals and all elements build. There's no way to make it more selective and creating |
jridgewell
pushed a commit
to jridgewell/amphtml
that referenced
this pull request
Jan 31, 2017
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Signalsobject is used across AMP elements, ampdoc and friendly embeds and potentially more in the future. Signals can be used for analytics or other dependent functions.This PR is a straightforward refactoring that extracts
Signalsclass and its tests into a separate module. No functional code changes.