amp-custom-ads: require CORS #7331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added description of how to use analytics, removed incorrect complaint that responsive images were erratic.
When an ad was not present, an attempt was still being made to find and render the template, which was causing errors. Documentation now has an example on how to use amp-analytics, and removed the wrong line about problems with image layout.
Removed unnecessary line of code, as well as id from amp-analytics example
Change the flag to require CORS to true, and update the ad documentation
|
/to @lannka (this is an XS one 😉) |
lannka
requested changes
Feb 3, 2017
| @@ -85,7 +85,7 @@ export class AmpAdCustom extends AMP.BaseElement { | |||
| if (!(fullUrl in ampCustomadXhrPromises)) { | |||
| // Here is a promise that will return the data for this URL | |||
| ampCustomadXhrPromises[fullUrl] = xhrFor(this.win).fetchJson(fullUrl, { | |||
| requireAmpResponseSourceOrigin: false, | |||
| requireAmpResponseSourceOrigin: true, | |||
There was a problem hiding this comment.
you can remove. true is the default.
lannka
approved these changes
Feb 10, 2017
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
* Updated custom ad documentation Added description of how to use analytics, removed incorrect complaint that responsive images were erratic. * Fixed error when no ad present, documentation update When an ad was not present, an attempt was still being made to find and render the template, which was causing errors. Documentation now has an example on how to use amp-analytics, and removed the wrong line about problems with image layout. * Removed redundant line of code Removed unnecessary line of code, as well as id from amp-analytics example * Issue ampproject#6758 - Require ampCors in custom ad Change the flag to require CORS to true, and update the ad documentation * Removed unnecessary parameter to fetchJson
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* Updated custom ad documentation Added description of how to use analytics, removed incorrect complaint that responsive images were erratic. * Fixed error when no ad present, documentation update When an ad was not present, an attempt was still being made to find and render the template, which was causing errors. Documentation now has an example on how to use amp-analytics, and removed the wrong line about problems with image layout. * Removed redundant line of code Removed unnecessary line of code, as well as id from amp-analytics example * Issue ampproject#6758 - Require ampCors in custom ad Change the flag to require CORS to true, and update the ad documentation * Removed unnecessary parameter to fetchJson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the flag to require CORS to true, and update the ad documentation
Closes #6758