Make sure fragment to be updated does not have leading # #7454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muxin
force-pushed
the
share-tracking-leave-pound-sign-off
branch
from
20d8f2d
to
f081c8d
Compare
lannka
approved these changes
Feb 10, 2017
| @@ -646,12 +646,12 @@ app.get(['/dist/cache-sw.min.html', '/dist/cache-sw.max.html'], function(req, re | |||
| */ | |||
| function replaceUrls(mode, file) { | |||
| if (mode) { | |||
| file = file.replace('https://cdn.ampproject.org/viewer/google/v5.js', 'https://cdn1.ampproject.org/viewer/google/v5.js'); | |||
There was a problem hiding this comment.
ha, the code was interesting :-) but i guess removing them will break something?
There was a problem hiding this comment.
I added the code below for general viewer url:
file = file.replace(/(https:\/\/cdn.ampproject.org\/viewer\/.+).max.js/g, '$1.js');
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.