Bump up inabox error log severity level, so that it will show up in StackDriver #7468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cramforce
requested changes
Feb 10, 2017
| @@ -129,6 +129,9 @@ func handle(w http.ResponseWriter, r *http.Request) { | |||
| runtime := r.URL.Query().Get("rt") | |||
| if runtime != "" { | |||
| errorType += "-" + runtime; | |||
| if runtime == "inabox" { | |||
| severity = "ERROR" | |||
lannka
commented
Feb 10, 2017
| @@ -129,6 +129,9 @@ func handle(w http.ResponseWriter, r *http.Request) { | |||
| runtime := r.URL.Query().Get("rt") | |||
| if runtime != "" { | |||
| errorType += "-" + runtime; | |||
| if runtime == "inabox" { | |||
| severity = "ERROR" | |||
cramforce
approved these changes
Feb 10, 2017
|
pls help deploy :-) |
|
Done
…On Thu, Feb 9, 2017 at 5:57 PM, Hongfei Ding ***@***.***> wrote:
pls help deploy :-)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#7468 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFeT--E4GAVFqvAk9-N7K65UPy0aRH1ks5ra8P6gaJpZM4L82s1>
.
|
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
…tackDriver (ampproject#7468) * Bump up inabox error log severity level, so that it will show up in StackDriver * address comments
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…tackDriver (ampproject#7468) * Bump up inabox error log severity level, so that it will show up in StackDriver * address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.