myWidget Ad extension #7471
Merged
myWidget Ad extension #7471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@3lvcz pls fix travis |
|
I fixed previous build error (missed property annotation), but it fails on tests now. It's our code is broken? |
|
Restarted the test build. Please check back in a bit. |
zhouyx
suggested changes
Feb 15, 2017
ads/mywidget.js
Outdated
| @@ -0,0 +1,78 @@ | |||
| /** | |||
| * Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
ads/mywidget.md
Outdated
| @@ -0,0 +1,40 @@ | |||
| <!--- | |||
| Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
ads/mywidget.js
Outdated
| @@ -0,0 +1,78 @@ | |||
| /** | |||
| * Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
ads/mywidget.md
Outdated
| @@ -0,0 +1,40 @@ | |||
| <!--- | |||
| Copyright 2015 The AMP HTML Authors. All Rights Reserved. | |||
ads/mywidget.md
Outdated
|
|
||
| Supported parameters: | ||
|
|
||
| - `data-cid` |
There was a problem hiding this comment.
I see that data-cid is a required parameter, I would suggest indicate that it is required here.
|
Few comments. LGTM in general |
|
Fixed year in license headers and described |
zhouyx
approved these changes
Feb 16, 2017
|
@3lvcz Thanks for the Pull Request. Merged. |
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* myWidget Ad extension * myWidget Ad extension - fix travis * myWidget Ad extension - fix travis * myWidget Ad extension - review fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull-request for "myWidget" ad.
Closes #6965
(broken closed one #7252)