Make viewport getScrollLeft return 0 #7492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvoytenko
approved these changes
Feb 11, 2017
muxin
force-pushed
the
viewport-getScrollLeft
branch
from
8b469f9
to
ceb4e00
Compare
muxin
force-pushed
the
viewport-getScrollLeft
branch
from
ceb4e00
to
260042d
Compare
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Feb 14, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #7355
Since we have
overflow-x: hiddenonhtml(in natural and ios-embed binding) and#i-amphtml-wrapper(in ios-embed-wrapper binding), the scrollLeft will always be 0.Also modified test cases that return non-zero value for getScrollLeft which couldn't happen in reality.