Validator rollup #7590
Merged
Validator rollup #7590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…q. $GLOBAL_ATTRS / $AMP_LAYOUT_ATTRS)
…rned strings are negative integers, allowing us to effectively mix them in with ids for complex messages (AttrSpec in this case).
…URL (if present).
…attribute does nothing, and is not mentioned in the spec.
…pec indicates that it's an enum, but the code just passes this through to the audio tag it creates, which treats this as true/false
powdercloud
approved these changes
Feb 16, 2017
This was referenced Feb 17, 2017
Closed
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* `<meta http-equiv=>` tags must have `<head>` as ancestor. * Small javascript performance optimizations. * Remove the unused errors_seen flag. * Use requires/satisfies mechanism instead of also_requires_tag. * Refactoring: Make getAttrsFor simpler and less forgiving (spec now req. $GLOBAL_ATTRS / $AMP_LAYOUT_ATTRS) * Bugfix: Use hasOwnProperty to check whether the key is in the map. * No need to copy over TagSpec.requires. * Share empty arrays for the specification objects where possible. * Allow form elements outside of form tags. * Update amp-access-laterpay. * Add string intern table and use it for simple attrs. The ids for interned strings are negative integers, allowing us to effectively mix them in with ids for complex messages (AttrSpec in this case). * Validate that amp-install-serviceworker[data-iframe-src] is an https URL (if present). * Restrict AMP4ADS extensions. * Allow empty `src` attribute for `amp-pixel`. * Restrict AMP4ADS extensions (part two). * Rely on the global class attr (w/ blacklist) instead of a locally defined one. * html_format unnecessary for both AMP and AMP4ADS extensions. * Elminate SimpleParsedAttrSpec class and use attr ids directly for simple attrs. * Add additional SVG 2.0 elements. * Add SVG filters to AMP Validator rules. * revision bump for amp-call-tracking * Use indexOf instead of startsWith for old Node.js version compat. * Allow empty `config` attribute for `amp-analytics`. * Refactoring: Move the parseAttrsFor method into the constructor of ParsedTagSpec. * Remove `autoplay` attribute from `<amp-anim>` tag in validator. This attribute does nothing, and is not mentioned in the spec. * Change amp-audio[autoplay] from an enum to a boolean attribute. The spec indicates that it's an enum, but the code just passes this through to the audio tag it creates, which treats this as true/false * In generated JS, use ids to identify attr lists (instead of attr lists names). * Remove the tagSpecId field from the TagSpec class. * Replace requires and satisfied fields with interned strings. * Update amp-bind validation rules From PR 7127
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<meta http-equiv=>tags must have<head>as ancestor.srcattribute foramp-pixel.configattribute foramp-analytics.autoplayattribute from<amp-anim>tag in validator. This … …