Created new endpoint for loading test pages in an iframe. #7615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lannka
requested changes
Feb 16, 2017
build-system/server.js
Outdated
| // Nest the response in an iframe. | ||
| // Example: | ||
| // http://localhost:8000/iframe/examples/ads.amp.max.html | ||
| app.use('/iframe/', function(req, res) { |
There was a problem hiding this comment.
i guess you need to strip out the leading '/iframe/'? you can do that by
also, use app.get instead of app.use
build-system/server.js
Outdated
| @@ -251,6 +251,16 @@ function proxyToAmpProxy(req, res, minify) { | |||
| }); | |||
| } | |||
|
|
|||
| // Returns an html blob with an iframe pointing to the provided url. | |||
| function nestResponseInIframe(url) { | |||
There was a problem hiding this comment.
to save space from this rapid growing file, let's just inline this function.
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…#7615) * Created new endpoint for loading test pages in an iframe. * Inlined function * Changed .use to .get
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is becoming increasingly common to want to run example pages within an iframe. Instead of redoing ever test and making N duplicates, I have added an endpoint to the test server, /iframe/, that allows you to load any page inside of an iframe.