Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Registration: Chunk #7880

Merged
merged 29 commits into from
Mar 22, 2017
Merged

Service Registration: Chunk #7880

merged 29 commits into from
Mar 22, 2017

Commits on Feb 28, 2017

  1. changes to service.js

    @kmh287
    kmh287 committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    beabda7 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @kmh287
    kmh287 committed Feb 28, 2017
    Configuration menu
    Copy the full SHA
    2ca1cdf View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2017

  1. chunk

    @kmh287
    kmh287 committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    b4c14b8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:kmh287/amphtml into service_regis… 

    …tration1
    @kmh287
    kmh287 committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    3869a83 View commit details
    Browse the repository at this point in the history

  3. register not instantiate in runtime.js

    @kmh287
    kmh287 committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    87d7204 View commit details
    Browse the repository at this point in the history

  4. pr comments

    @kmh287
    kmh287 committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    83a3273 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2017

  1. pr comments

    @kmh287
    kmh287 committed Mar 2, 2017
    Configuration menu
    Copy the full SHA
    e718da2 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2017

  1. worked out some edge cases

    @kmh287
    kmh287 committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    6f018b3 View commit details
    Browse the repository at this point in the history

  2. pr comments

    @kmh287
    kmh287 committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    a3fa55b View commit details
    Browse the repository at this point in the history

  3. pr comments

    @kmh287
    kmh287 committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    abeedb0 View commit details
    Browse the repository at this point in the history

  4. cleanup

    @kmh287
    kmh287 committed Mar 3, 2017
    Configuration menu
    Copy the full SHA
    20e9e5e View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2017

  1. pr comments and another test

    @kmh287
    kmh287 committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    7f3378f View commit details
    Browse the repository at this point in the history

  2. pr comments

    @kmh287
    kmh287 committed Mar 6, 2017
    Configuration menu
    Copy the full SHA
    c463251 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2017

  1. service registration then promise edge case

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    536f724 View commit details
    Browse the repository at this point in the history

  2. swap opt_ctor and opt_factory args as ctor is much more common

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    bb3ec75 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'service_registration1' into service_registration15_chunk

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    93a96db View commit details
    Browse the repository at this point in the history

  4. merge

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    9d23a77 View commit details
    Browse the repository at this point in the history

  5. test fix

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    4ff62ad View commit details
    Browse the repository at this point in the history

  6. Merge branch 'service_registration1' into service_registration15_chunk

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    1dae71b View commit details
    Browse the repository at this point in the history

  7. refactoring woes

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    d2a11b5 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'service_registration1' into service_registration15_chunk

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    b9e150f View commit details
    Browse the repository at this point in the history

  9. fix types

    @kmh287
    kmh287 committed Mar 7, 2017
    Configuration menu
    Copy the full SHA
    12199bf View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2017

  1. pr comments

    @kmh287
    kmh287 committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    0d424d6 View commit details
    Browse the repository at this point in the history

  2. pr comment

    @kmh287
    kmh287 committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    38962a9 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2017

  1. Merge branch 'service_registration1' into service_registration15_chunk

    @kmh287
    kmh287 committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    02b4f2e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of github.com:kmh287/amphtml into service_regis… 

    …tration15_chunk
    @kmh287
    kmh287 committed Mar 9, 2017
    Configuration menu
    Copy the full SHA
    389b10e View commit details
    Browse the repository at this point in the history

Commits on Mar 16, 2017

  1. pr comments

    @kmh287
    kmh287 committed Mar 16, 2017
    Configuration menu
    Copy the full SHA
    7520012 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2017

  1. cleanup

    @kmh287
    kmh287 committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    57c3a50 View commit details
    Browse the repository at this point in the history

  2. resolve merge conflicts

    @kmh287
    kmh287 committed Mar 17, 2017
    Configuration menu
    Copy the full SHA
    9de9664 View commit details
    Browse the repository at this point in the history