Add client check/formatting to AdSense Fast Fetch #7977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ormatted properly
|
cc @ampproject/a4a |
taymonbeal
reviewed
Mar 6, 2017
| @@ -105,7 +105,8 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A { | |||
|
|
|||
| /** @override */ | |||
| isValidElement() { | |||
| return isGoogleAdsA4AValidEnvironment(this.win) && this.isAmpAdElement(); | |||
| return !!this.element.getAttribute('data-ad-client') && | |||
There was a problem hiding this comment.
This seems redundant, since if there's no client it'll get filtered out by adsenseIsA4AEnabled?
There was a problem hiding this comment.
I agree, just being overly cautious.
taymonbeal
approved these changes
Mar 6, 2017
|
@lannka please merge once build is green. Thanks! |
lannka
approved these changes
Mar 6, 2017
kmh287
pushed a commit
to kmh287/amphtml
that referenced
this pull request
Mar 13, 2017
…ormatted properly (ampproject#7977)
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
…ormatted properly (ampproject#7977)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add existence check for data-ad-client as part of isValidElement otherwise request could be sent with missing id causing 400 response. Ensure that client is properly formatted (lower case with ca- prefix).